Make Windows directory layout uniform with everything else #29500
Conversation
…metry with all other platforms.
|
How does this interact with library search? In my memory libraries on windows would be put alongside the executable, so meddling with library search paths would be unnecessary. |
|
@nagisa I believe this does not change the location of the DLLs for rustc itself, but rather changes the location of rustlib which is the target specific libraries. |
|
Yah, dlls are still under |
| @@ -295,7 +294,7 @@ fn find_libdir(sysroot: &Path) -> String { | |||
|
|
|||
| #[cfg(windows)] | |||
| fn find_libdir(_sysroot: &Path) -> String { | |||
| "bin".to_string() | |||
| "lib".to_string() | |||
There was a problem hiding this comment.
I think with this change we could actually remove the #[cfg] from this function altogether perhaps?
There was a problem hiding this comment.
Do we need to do lib32/lib64 probing on Windows? I suppose there's no harm in that though...
There was a problem hiding this comment.
Nah not as far as I know at least, it'd basically just be a noop there
|
r+ from me, thanks @vadimcn! |
|
cc @vosen |
According to a recent [discussion on IRC](https://botbot.me/mozilla/rust-tools/2015-10-27/?msg=52887517&page=2), there's no good reason for Windows builds to store target libraries under `bin`, when on every other platform they are under `lib`. This might be a [breaking-change] for some users. I am pretty sure VisualRust has that path hard-coded somewhere. r? @brson
|
I wish I had seen this before it landed. I do not fully understand the fallout offhand. |
|
My main concern was how this would affect rust-installer/rustup, but after a quick look I think they will not be impacted. |
According to a recent discussion on IRC, there's no good reason for Windows builds to store target libraries under
bin, when on every other platform they are underlib.This might be a [breaking-change] for some users. I am pretty sure VisualRust has that path hard-coded somewhere.
r? @brson