Skip to content

Report errors at macro definition, not expansion #29828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2015
Merged

Report errors at macro definition, not expansion #29828

merged 3 commits into from
Nov 16, 2015
+83 −50

Conversation

sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented Nov 14, 2015

Fix #27409.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 16, 2015
@alexcrichton
Copy link
Member

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned alexcrichton Nov 16, 2015
@alexcrichton
Copy link
Member

also cc @sfackler

@nrc
Copy link
Member

nrc commented Nov 16, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 16, 2015

📌 Commit cce7b8b has been approved by nrc

@bors
Copy link
Collaborator

bors commented Nov 16, 2015

⌛ Testing commit cce7b8b with merge bf78389...

bors added a commit that referenced this pull request Nov 16, 2015
@bors
Auto merge of #29828 - sanxiyn:check-macro, r=nrc
bf78389 
Fix #27409.
@bors
Copy link
Collaborator

bors commented Nov 16, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit cce7b8b into rust-lang:master Nov 16, 2015
@sanxiyn sanxiyn deleted the check-macro branch November 16, 2015 07:53
@sanxiyn sanxiyn mentioned this pull request Jan 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrc nrc

Labels

relnotes Marks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sanxiyn @rust-highfive @alexcrichton @nrc @bors