Only print colored error messages if the output is going to the screen #3035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_type() method can hint to users what kind of item might be under the hood.
ghost
assigned
|
I'll merge this -- there's just one tiny change I want to make. |
|
Merged, thanks! I changed two places in the code to return implicitly rather than with a |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
Format generics on associated types
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 22, 2023
bump serde bump to a version with the binary blob removed also, respect CARGO_EXTRA_FLAGS in more places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tools print color if isatty() returns true. This patch adds an io::writer.get_type() method that gives hints as to the underlying writer type. The diagnostics code then uses this to determine if it should print in colour or not.