Skip to content

mk: Fix compiling powerpc64/armv7 #31290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2016
Merged

mk: Fix compiling powerpc64/armv7 #31290

merged 2 commits into from
Jan 30, 2016
+4 −3

Conversation

alexcrichton
Copy link
Member

We forgot to pass down the -m64 flag to gcc, so we were actually compiling
powerpc code which would then later fail to link!

@alexcrichton
mk: Fix compiling jemalloc for powerpc64
7e1acc5 
We forgot to pass down the `-m64` flag to gcc, so we were actually compiling
powerpc code which would then later fail to link!
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
mk: Fix cross-compiling to armv7-unknown-linux-gnu
ea31ff2 
The cross prefix was not likely the actual compiler that needed to be used, but
rather the standard `arm-linux-gnueabihf-gcc` compiler can just be used with
`-march=armv7`.
@alexcrichton alexcrichton changed the title mk: Fix compiling jemalloc for powerpc64 mk: Fix compiling powerpc64/armv7 Jan 29, 2016
@alexcrichton
Copy link
Member Author

Updated with an extra commit for armv7-unknown-linux-gnu as well (cc @fabricedesre)

@brson
Copy link
Contributor

brson commented Jan 29, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 29, 2016

📌 Commit ea31ff2 has been approved by brson

@alexcrichton
Copy link
Member Author

@bors: rollup

@bors
Copy link
Collaborator

bors commented Jan 30, 2016

⌛ Testing commit ea31ff2 with merge 37ffb15...

@bors
Copy link
Collaborator

bors commented Jan 30, 2016

💔 Test failed - auto-linux-cross-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Fri, Jan 29, 2016 at 9:38 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-cross-opt
http://buildbot.rust-lang.org/builders/auto-linux-cross-opt/builds/1073

—
Reply to this email directly or view it on GitHub
#31290 (comment).

@Manishearth Manishearth mentioned this pull request Jan 30, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 30, 2016
@Manishearth
Rollup merge of rust-lang#31290 - alexcrichton:fix-powerpc64, r=brson
5ff52db 
We forgot to pass down the `-m64` flag to gcc, so we were actually compiling
powerpc code which would then later fail to link!
bors added a commit that referenced this pull request Jan 30, 2016
@bors
Auto merge of #31305 - Manishearth:rollup, r=Manishearth
27380a3 
- Successful merges: #31099, #31244, #31280, #31290, #31292, #31294, #31295, #31296
- Failed merges:
@bors bors merged commit ea31ff2 into rust-lang:master Jan 30, 2016
@fabricedesre
Copy link
Contributor

@alexcrichton why did you need the change to armv7?

@alexcrichton alexcrichton deleted the fix-powerpc64 branch January 30, 2016 18:39
@alexcrichton
Copy link
Member Author

For me at least I'm not sure how to attain armv7-unknown-linux-gnueabihf-gcc, but I've seen arm-linux-gnueabihf-gcc running around with the ability to set the target CPU, and that's all that changed here (the default CROSS_PREFIX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alexcrichton @rust-highfive @brson @bors @fabricedesre @MagaTailor