test: Fix a spuriously failing test on valgrind #31781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear to me whether this test failing under valgrind is actually legit. The test only fails in valgrind when everything is dynamically linked, and it appears to work when statically linked. For now just add the `// no-prefer-dynamic` directive and let's just chalk it up to a weird valgrind issue. Closes rust-lang#31328
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=100000 |
|
📌 Commit 595d5b2 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 20, 2016
It's unclear to me whether this test failing under valgrind is actually legit. The test only fails in valgrind when everything is dynamically linked, and it appears to work when statically linked. For now just add the `// no-prefer-dynamic` directive and let's just chalk it up to a weird valgrind issue. Closes #31328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear to me whether this test failing under valgrind is actually legit.
The test only fails in valgrind when everything is dynamically linked, and it
appears to work when statically linked.
For now just add the
// no-prefer-dynamicdirective and let's just chalk it upto a weird valgrind issue.
Closes #31328