Minor cleanup for 'src/librustc_driver/lib.rs' #32369
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -218,8 +218,7 @@ fn make_output(matches: &getopts::Matches) -> (Option<PathBuf>, Option<PathBuf>) | |||
|
|
|||
| // Extract input (string or file and optional path) from matches. | |||
| fn make_input(free_matches: &[String]) -> Option<(Input, Option<PathBuf>)> { | |||
| if free_matches.len() == 1 { | |||
| let ifile = &free_matches[0][..]; | |||
| if let Some(ifile) = free_matches.first() { | |||
There was a problem hiding this comment.
Are you sure that free_matches.len() is always 1 or 0? This seems to change the behavior if it's, say, 2 or 3.
There was a problem hiding this comment.
Ah you're right. I'll remove this commit.
frewsxcv
force-pushed
the
librustc-driver-lib
branch
from
dc038a9 to
4d52b0f
Compare
Minor cleanup for 'src/librustc_driver/lib.rs' Reading through this file my first time. Cleaned up some stuff on the way.
Reading through this file my first time. Cleaned up some stuff on the way.