some Python nits and fixes #33141
Merged
some Python nits and fixes #33141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| continue | ||
| a, b = line.split(": ", 1) | ||
| data[a] = b | ||
| return data | ||
| return data |
There was a problem hiding this comment.
FYI, you can do this with a single comprehension:
with open(nightlies, 'r') as nightlies:
return dict(
line.split(": ", 1)
for line in nightlies
if line.strip() and not line.startswith('#')
)However, this is obviously a matter of style (and your way is probably more readable to someone who doesn't do a lot of functional programming).
There was a problem hiding this comment.
Interesting approach. Looks elegant.
|
@bors r+ |
|
📌 Commit a422b7e has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.