introduce a specializes cache #33695
Merged
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jonathandturner -- thus resulted from examining some outliers that @jonathandturner brought up |
|
Nice! @bors: r+ |
|
📌 Commit 2714ef5 has been approved by |
This query is frequently used during trait selection and caching the result can be a reasonable performance win.
nikomatsakis
force-pushed
the
spezializes-cache
branch
from
2714ef5 to
29dad1a
Compare
|
@bors r=aturon |
|
📌 Commit 29dad1a has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 18, 2016
…turon introduce a specializes cache This query is frequently used during trait selection and caching the result can be a reasonable performance win. The one case I examined thus far was the mrusty package (v0.5.1), where I saw an improvement in "typeck item bodies" from ~8.3s to ~1.9s. r? @aturon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query is frequently used during trait selection and caching the
result can be a reasonable performance win.
The one case I examined thus far was the mrusty package (v0.5.1), where I saw an improvement in "typeck item bodies" from ~8.3s to ~1.9s.
r? @aturon