Rollup of 8 pull requests #33959
Merged
Rollup of 8 pull requests #33959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
May 30, 2016
Manishearth
commented
- Successful merges: Fix compile_fail tag #33793, Added examples/docs to split in str.rs #33893, Improve E0132 error explanation #33912, Improve E0133 error explanation #33913, Improve err expl #33914, rustfmt liballoc folder #33917, run rustfmt on librand folder #33937, run rustfmt on libunwind #33938
- Failed merges:
…expected to and was still considered 'ok') * Fix error explanations tests/tags
Added documentation clarifying the behavior of split when used with the empty string and contiguous separators.
…laumeGomez Fix compile_fail tag Fixes rust-lang#33780 r? @steveklabnik
…uillaumeGomez Added examples/docs to split in str.rs Added documentation clarifying the behavior of split when used with the empty string and contiguous separators. Addresses issue [33882](rust-lang#33882). This is my first time contributing to rust, so forgive me if I'm skipping any of the contribution steps. Fixes rust-lang#33882
…veklabnik Improve E0132 error explanation r? @steveklabnik
…llaumeGomez Improve E0133 error explanation r? @steveklabnik
…GuillaumeGomez Improve err expl r? @steveklabnik
…uillaumeGomez rustfmt liballoc folder
…illaumeGomez run rustfmt on librand folder
…Manishearth run rustfmt on libunwind
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=20 |
|
📌 Commit 9d2ec40 has been approved by |
|
@bors force |
1 similar comment
|
@bors force |
bors
added a commit
that referenced
this pull request
May 30, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.