Skip to content

fix build for clang 8.0 #34340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2016
Merged

fix build for clang 8.0 #34340

merged 1 commit into from
Jun 20, 2016

Conversation

marudor
Copy link
Contributor

@marudor marudor commented Jun 18, 2016

With 10.12 and XCode 8-beta we got clang 8.
Simple addition as clang 8 will build as well.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@japaric
Copy link
Member

japaric commented Jun 18, 2016

@bors r+ rollup

Thanks for testing this and sending a PR!

@bors
Copy link
Collaborator

bors commented Jun 18, 2016

📌 Commit 7508de5 has been approved by japaric

@bors
Copy link
Collaborator

bors commented Jun 20, 2016

⌛ Testing commit 7508de5 with merge fa4cf7b...

bors added a commit that referenced this pull request Jun 20, 2016
fix build for clang 8.0

With 10.12 and XCode 8-beta we got clang 8.
Simple addition as clang 8 will build as well.
@bors bors merged commit 7508de5 into rust-lang:master Jun 20, 2016
bors added a commit that referenced this pull request Jun 20, 2016
Rollup of 4 pull requests

- Successful merges: #34313, #34335, #34340, #34356
- Failed merges:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants