Skip to content

[WIP] MIR Move up propagation #34585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

scottcarr
Copy link
Contributor

This is a work-in-progress minimum-viable-product version of move up propagation for Mir.

At a high level the idea is to transform:

tmp0 = x;
... // no uses of tmp0
tmp2 = tmp0;

Into:

// optimized out tmp0 = x;
tmp2 = x;
... // no uses of tmp0

The current implementation does not manipulate the MIR CFG so it doesn't invalidate previous CFG analyses.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@scottcarr
Copy link
Contributor Author

r? @nikomatsakis

@scottcarr
Copy link
Contributor Author

This PR assumes #34556 lands

}
}

fn any_funny_business(ldef: &UseDefLocation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny name for a function

@scottcarr
Copy link
Contributor Author

I made a new PR for an implementation without post dominators: #34693. Probably we should close this PR and discuss in the new PR?

@nikomatsakis
Copy link
Contributor

Yes, let's close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants