Move LLVM cleanup so modules are accessible during after_llvm phase
#34594
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -289,6 +296,7 @@ pub struct CompileController<'a> { | |||
| pub after_hir_lowering: PhaseController<'a>, | |||
| pub after_analysis: PhaseController<'a>, | |||
| pub after_llvm: PhaseController<'a>, | |||
| pub after_compilation_done: PhaseController<'a>, | |||
There was a problem hiding this comment.
could you change the name to just compilation_done
|
r+ with the renaming and squashing the last two commits. |
|
@nrc done. All good? |
|
All good, thanks! @bors: r+ |
|
📌 Commit 5b0f334 has been approved by |
Move LLVM cleanup so modules are accessible during `after_llvm` phase Fix for #34432. Also added a new phase controller `after_compilation_done` that gets called at the very end (i.e. after linking) at the suggestion of @nrc. The added test will segfault if the modules get deallocated too early, so it ensures the LLVM is not prematurely cleaned up. r? @nrc
Fix for #34432. Also added a new phase controller
after_compilation_donethat gets called at the very end (i.e. after linking) at the suggestion of @nrc. The added test will segfault if the modules get deallocated too early, so it ensures the LLVM is not prematurely cleaned up.r? @nrc