Use lazy range in gdb pretty printers #34669
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| import debugger_pretty_printers_common as rustpp | ||
|
|
||
| if sys.version_info.major >= 3: | ||
| xrange = range |
There was a problem hiding this comment.
Could you be sure to add a comment here as well indicating why we're doing this?
|
Ah I've gone ahead and added a comment in #34689, and I'll try to land this as part of that. |
|
Sorry, I didn't see your comment about adding a comment. |
|
No worries! Just a minor nit anyway :) |
First attempt to fix nightlies This is just #34669 but I added some comments so it can land.
|
☔ The latest upstream changes (presumably #34689) made this pull request unmergeable. Please resolve the merge conflicts. |
No description provided.