Clarify rustbuild + msvc + vcvars in README #34690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
clarify-vcvars
branch
from
d905984 to
c640060
Compare
|
Seems fine. |
| newer with the C++ tools. Then all you need to do is invoke the appropriate | ||
| vcvars bat file and kick off rustbuild. | ||
| The old build system, based on makefiles, is currently being rewritten into a | ||
| Rust-based build system called rustbuild. This can be used to boostrap the |
|
r=me |
The invocation of vcvars is only needed for versions of Visual Studio that rustbuild or cmake doesn't understand, but if older versions are installed then there's no need to call vcvars. Closes rust-lang#34576
alexcrichton
force-pushed
the
clarify-vcvars
branch
from
c640060 to
b67f23c
Compare
|
@bors: r=brson |
|
📌 Commit b67f23c has been approved by |
bors
added a commit
that referenced
this pull request
Jul 8, 2016
Clarify rustbuild + msvc + vcvars in README The invocation of vcvars is only needed for versions of Visual Studio that rustbuild or cmake doesn't understand, but if older versions are installed then there's no need to call vcvars. Closes #34576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invocation of vcvars is only needed for versions of Visual Studio that
rustbuild or cmake doesn't understand, but if older versions are installed then
there's no need to call vcvars.
Closes #34576