Remove unnecessarily mutable reference in doc example. #34717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,6 +155,7 @@ pub struct Sink { _priv: () } | |||
| /// let mut buffer = vec![1, 2, 3, 5, 8]; | |||
| /// let num_bytes = io::sink().write(&mut buffer).unwrap(); | |||
| /// assert_eq!(num_bytes, 5); | |||
| /// assert_eq!(buffer, &[1, 2, 3, 5, 8]); | |||
There was a problem hiding this comment.
Maybe instead of this, just change the example so it doesn't mutably borrow the buffer?
There was a problem hiding this comment.
Definitely a good idea. Just made that change.
frewsxcv
changed the title
std::io::sink does not affect the data.
|
@bors: r+ rollup |
|
📌 Commit fc2123a has been approved by |
bors
added a commit
that referenced
this pull request
Jul 9, 2016
Remove unnecessarily mutable reference in doc example. None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.