Rollup of 4 pull requests #34883
Closed
Rollup of 4 pull requests #34883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra newlines in MIR dump
…omez Partial rewrite/expansion of `Vec::truncate` documentation. None
…richton Refactored code to access TLS only in case of panic (II) Fixes rust-lang#34787 r? @alexcrichton Do it **very** carefully this time!
Do not resolve inherent static methods from other crates prematurely Under some specific circumstances paths like `Type::method` can be resolved early in rustc_resolve instead of type checker. `Type` must be defined in another crate, it should be an enum or a trait object (i.e. a type that acts as a "module" in resolve), and `method` should be an inherent static method. As a result, such paths don't go through `resolve_ufcs`, may be resolved incorrectly and break some invariants in type checker. This patch removes special treatment of such methods. The removed code was introduced in rust-lang@2bd46e7 to fix a problem that no longer exists. r? @jseyfried
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=5 |
|
📌 Commit 6f9f903 has been approved by |
|
⌛ Testing commit 6f9f903 with merge 8750c89... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vec::truncatedocumentation. #34853, Refactored code to access TLS only in case of panic (II) #34866, Do not resolve inherent static methods from other crates prematurely #34871