Update E0379 to new format #35338 #35364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Looks good! @bors r+ rollup |
|
📌 Commit 764d5cf has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 5, 2016
Update E0379 to new format rust-lang#35338 Fixes rust-lang#35338, as part of rust-lang#35233. But this does not include the bonus. From my understanding a Span is defined by a `hi` and a `lo` position within some context. A naive way would be to mutate the span so that `hi` is 5 positions from `lo` which corresponds to the `const` keyword. But this methods feels a bit rigid. Is there another way to do this? r? @jonathandturner
Closed
bors
added a commit
that referenced
this pull request
Aug 6, 2016
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Aug 6, 2016
Update E0379 to new format rust-lang#35338 Fixes rust-lang#35338, as part of rust-lang#35233. But this does not include the bonus. From my understanding a Span is defined by a `hi` and a `lo` position within some context. A naive way would be to mutate the span so that `hi` is 5 positions from `lo` which corresponds to the `const` keyword. But this methods feels a bit rigid. Is there another way to do this? r? @jonathandturner
bors
added a commit
that referenced
this pull request
Aug 6, 2016
jseyfried
added a commit
to jseyfried/rust
that referenced
this pull request
Aug 28, 2016
Move E0379 check from typeck to ast validation Part of rust-lang#35233. Extension of rust-lang#35338, rust-lang#35364. Fixes rust-lang#35404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35338, as part of #35233.
But this does not include the bonus. From my understanding a Span is defined by a
hiand aloposition within some context. A naive way would be to mutate the span so thathiis 5 positions fromlowhich corresponds to theconstkeyword. But this methods feels a bit rigid. Is there another way to do this?r? @jonathandturner