Skip to content

A couple refactorings in librustdoc. #36872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2016
Merged

A couple refactorings in librustdoc. #36872

merged 2 commits into from
Oct 1, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv
Migrate Item ➡ ItemType function to method.
c66c453
@frewsxcv
Simplify logic around Context's root_path.
7732e62 
Was previously cached and maintained in the `Context`, which to me seems
overkill.
@GuillaumeGomez
Copy link
Member

Thanks!

Once travis is green, I r+.

@frewsxcv
Copy link
Member Author

@GuillaumeGomez ✅

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 1, 2016

📌 Commit 7732e62 has been approved by GuillaumeGomez

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 1, 2016
@Manishearth
Rollup merge of rust-lang#36872 - frewsxcv:rustdoc, r=GuillaumeGomez
2e5837a 
A couple refactorings in librustdoc.

None
@Manishearth Manishearth mentioned this pull request Oct 1, 2016
Merged
bors added a commit that referenced this pull request Oct 1, 2016
@bors
Auto merge of #36885 - Manishearth:rollup, r=Manishearth
ab38d52 
Rollup of 6 pull requests

- Successful merges: #36865, #36872, #36873, #36877, #36880, #36882
- Failed merges:
@bors bors merged commit 7732e62 into rust-lang:master Oct 1, 2016
@frewsxcv frewsxcv deleted the rustdoc branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frewsxcv @GuillaumeGomez @bors