Skip to content

Match guessing game output to newest language version #37483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2016
Merged

Match guessing game output to newest language version #37483

merged 1 commit into from
Nov 9, 2016

Conversation

sugar700
Copy link
Contributor

Cargo now informs that it has finished, and there is new error format.

@sugar700
doc: guessing-game.md: Match output to newest language version
5704a53 
Cargo now informs that it has finished, and there is new error format.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

thank you! Sorry about the delay.

@bors
Copy link
Collaborator

bors commented Nov 7, 2016

📌 Commit 5704a53 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Nov 7, 2016

⌛ Testing commit 5704a53 with merge 7b46491...

@bors
Copy link
Collaborator

bors commented Nov 7, 2016

💔 Test failed - auto-linux-cross-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Nov 7, 2016 at 5:27 PM, bors [email protected] wrote:

💔 Test failed - auto-linux-cross-opt
https://buildbot.rust-lang.org/builders/auto-linux-cross-opt/builds/4137

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#37483 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95O_bcZXKo-wFIJwq1xS1WWwsVBuSks5q77PpgaJpZM4KkW21
.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 8, 2016
@steveklabnik
Rollup merge of rust-lang#37483 - xfix:patch-1, r=steveklabnik
2b2e9fc 
Match guessing game output to newest language version

Cargo now informs that it has finished, and there is new error format.
@steveklabnik steveklabnik mentioned this pull request Nov 8, 2016
Merged
bors added a commit that referenced this pull request Nov 9, 2016
@bors
Auto merge of #37657 - steveklabnik:rollup, r=steveklabnik
02aa428 
Rollup of 8 pull requests

- Successful merges: #35102, #37425, #37483, #37588, #37601, #37610, #37650, #37652
- Failed merges:
@bors bors merged commit 5704a53 into rust-lang:master Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Manishearth Manishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sugar700 @rust-highfive @steveklabnik @bors @alexcrichton @Manishearth