make HR_LIFETIME_IN_ASSOC_TYPE deny-by-default

[nikomatsakis]

It's time to fix issue #32330.

cc #33685
cc @arielb1

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[nikomatsakis]

This needs a crater run.

[eddyb]

Please switch to Forbid for the crater run. r=me otherwise.

[KalitaAlexey]

Dear @nikomatsakis, are you going to write tests for that case?

[nikomatsakis]

Crater report available here.

• glib-0.1.0 (before) (after) -- inconclusive
• more-asserts-0.1.0 (before) (after) -- inconclusive
• systemstat-0.1.0 (before) (after) -- inconclusive
• human_name-0.6.2 (before) (after) -- actual regression
• karaorust-0.0.1 (before) (after) -- inconclusive
• external_set-0.1.1 (before) (after) -- inconclusive

[nikomatsakis]

@KalitaAlexey there are many tests for the ling that already exist, they are just already set to deny

[nikomatsakis]

@djudd -- note that according to this crater run, your package human-name contains a future incompatibility warning (#33685). This warning will soon change to a hard error. I tried checking it out and building it locally but I got errors (at least with the latest nightly) related to the package phf_macros (I'm actually not sure how the crater run managed to succeed -- doing a bit more investigation).

In any case, here are the errors we see. I suspect the fix is to change the signature of transliterate to the following:

pub fn transliterate(c: char) -> Chars<'static>

but I am not entirely sure until I am able to experiment. (Note that the need to do this is itself a compiler bug, as described in #32330, but fixing that bug is (somewhat ironically) blocked on converting this lint into a hard error.)

error: lifetime parameter `'a` declared on fn `utils::transliterate` appears only in the return type, but here is required to be higher-ranked, which means that `'a` must appear in both argument and return types, #[forbid(hr_lifetime_in_assoc_type)] on by default
   --> src/comparison.rs:413:33
    |
413 |                                .filter_map(lowercase_if_alpha);
    |                                 ^^^^^^^^^^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #33685 <https://github.com/rust-lang/rust/issues/33685>

error: lifetime parameter `'a` declared on fn `utils::transliterate` appears only in the return type, but here is required to be higher-ranked, which means that `'a` must appear in both argument and return types, #[forbid(hr_lifetime_in_assoc_type)] on by default
   --> src/comparison.rs:417:37
    |
417 |                                    .filter_map(lowercase_if_alpha);
    |                                     ^^^^^^^^^^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #33685 <https://github.com/rust-lang/rust/issues/33685>

error: lifetime parameter `'a` declared on fn `utils::transliterate` appears only in the return type, but here is required to be higher-ranked, which means that `'a` must appear in both argument and return types, #[forbid(hr_lifetime_in_assoc_type)] on by default
   --> src/lib.rs:405:34
    |
405 |                                 .rev();
    |                                  ^^^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #33685 <https://github.com/rust-lang/rust/issues/33685>

I'll update with more info when I figure out what's happening with the phf_macros crate.

[djudd]

@nikomatsakis that fix appears to work - thanks! (I didn't see phf_macros-related errors locally.)

[nikomatsakis]

@bors r=eddyb

[bors]

📌 Commit a257d8d has been approved by eddyb

[bors]

⌛ Testing commit a257d8d with merge 3bf2be9...

[bors]

💔 Test failed - auto-win-gnu-32-opt

[alexcrichton]

@bors: retry

On Tue, Nov 22, 2016 at 9:13 AM, bors [email protected] wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/6242

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#37843 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95MrOAcTM6MWCDXT5NE3ZTPiwNOR0ks5rAwZ_gaJpZM4K12wY
.

[bors]

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt-rustbuild, auto-linux-musl-64-opt, auto-mac-32-opt, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-64-opt...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 3bf2be9 to master...