Skip to content

incr.comp.: Avoid creating an edge to DepNode::Krate when generating debuginfo namespaces. #38243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/librustc/hir/map/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,9 @@ impl<'ast> Map<'ast> {
id = p;
}

RootCrate =>
return DepNode::Krate,
RootCrate => {
return DepNode::Hir(DefId::local(CRATE_DEF_INDEX));
}

RootInlinedParent(_) =>
bug!("node {} has inlined ancestor but is not inlined", id0),
Expand Down Expand Up @@ -782,7 +783,7 @@ impl<'ast> Map<'ast> {
Some(EntryVisibility(_, &Visibility::Restricted { ref path, .. })) => path.span,
Some(EntryVisibility(_, v)) => bug!("unexpected Visibility {:?}", v),

Some(RootCrate) => self.krate().span,
Some(RootCrate) => self.forest.krate.span,
Some(RootInlinedParent(parent)) => parent.body.span,
Some(NotPresent) | None => {
bug!("hir::map::Map::span: id not in map: {:?}", id)
Expand Down
5 changes: 3 additions & 2 deletions src/librustc_incremental/calculate_svh/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,9 @@ pub fn compute_incremental_hashes_map<'a, 'tcx: 'a>(tcx: TyCtxt<'a, 'tcx, 'tcx>)
hash_spans: hash_spans,
};
record_time(&tcx.sess.perf_stats.incr_comp_hashes_time, || {
visitor.calculate_def_id(DefId::local(CRATE_DEF_INDEX),
|v| visit::walk_crate(v, krate));
visitor.calculate_def_id(DefId::local(CRATE_DEF_INDEX), |v| {
v.hash_crate_root_module(krate);
});
krate.visit_all_item_likes(&mut visitor.as_deep_visitor());

for macro_def in krate.exported_macros.iter() {
Expand Down
22 changes: 21 additions & 1 deletion src/librustc_incremental/calculate_svh/svh_visitor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -619,9 +619,10 @@ impl<'a, 'hash, 'tcx> visit::Visitor<'tcx> for StrictVersionHashVisitor<'a, 'has
visit::walk_item(self, i)
}

fn visit_mod(&mut self, m: &'tcx Mod, _s: Span, n: NodeId) {
fn visit_mod(&mut self, m: &'tcx Mod, span: Span, n: NodeId) {
debug!("visit_mod: st={:?}", self.st);
SawMod.hash(self.st);
hash_span!(self, span);
visit::walk_mod(self, m, n)
}

Expand Down Expand Up @@ -1085,4 +1086,23 @@ impl<'a, 'hash, 'tcx> StrictVersionHashVisitor<'a, 'hash, 'tcx> {
token::Token::Shebang(val) => val.as_str().hash(self.st),
}
}

pub fn hash_crate_root_module(&mut self, krate: &'tcx Crate) {
let hir::Crate {
ref module,
ref attrs,
span,

// These fields are handled separately:
exported_macros: _,
items: _,
impl_items: _,
exprs: _,
} = *krate;

visit::Visitor::visit_mod(self, module, span, ast::CRATE_NODE_ID);
// Crate attributes are not copied over to the root `Mod`, so hash them
// explicitly here.
hash_attrs!(self, attrs);
}
}
40 changes: 40 additions & 0 deletions src/test/incremental/issue-38222.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test that debuginfo does not introduce a dependency edge to the Krate
// dep-node.

// revisions:rpass1 rpass2

#![feature(rustc_attrs)]


#![rustc_partition_translated(module="issue_38222-mod1", cfg="rpass2")]

// If trans had added a dependency edge to the Krate dep-node, nothing would
// be re-used, so checking that this module was re-used is sufficient.
#![rustc_partition_reused(module="issue_38222", cfg="rpass2")]

//[rpass1] compile-flags: -C debuginfo=1
//[rpass2] compile-flags: -C debuginfo=1

pub fn main() {
mod1::some_fn();
}

mod mod1 {
pub fn some_fn() {
let _ = 1;
}

#[cfg(rpass2)]
fn _some_other_fn() {
}
}