-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix process module tests to run on Windows #38797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @retep998 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
You have a lot of missing spaces, in particular |
don't rely on cmd.exe because in future versions of windows that will be removed for powershell. Not unless you expect them to rip cmd.exe from Windows 7. |
|
r=me with fixed formatting (#38797 (comment)) |
@bors r+ |
📌 Commit 7152bce has been approved by |
@AraHaan To dissuade your fears, Microsoft has even published a blog post saying that they will not be removing cmd.exe in the near or distant future. https://blogs.msdn.microsoft.com/commandline/2017/01/04/rumors-of-cmds-death-have-been-greatly-exaggerated/ |
⌛ Testing commit 7152bce with merge 1d5f4e8... |
💔 Test failed - status-travis |
@bors: retry
* sccache timeout
…On Sat, Jan 7, 2017 at 4:09 PM bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189889098>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38797 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95GH16_ihRtNqqWDvTY3VAHgzpELtks5rQClLgaJpZM4LZlIt>
.
|
⌛ Testing commit 7152bce with merge f258d84... |
💔 Test failed - status-travis |
@bors: retry
* osx network timeout
…On Sat, Jan 7, 2017 at 8:14 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189920358>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38797 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95CTOGJcAzjxLrbaP121qkjcEEI1dks5rQGLDgaJpZM4LZlIt>
.
|
💔 Test failed - status-travis |
@bors: retry
* OS X linker segfaulted
…On Sun, Jan 8, 2017 at 3:36 AM bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189956908>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38797 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95A0YSfz1tGZVLKfQay1ha9vjexmRks5rQMo4gaJpZM4LZlIt>
.
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #38565
r? @retep998