Rollup of 8 pull requests #42233
Closed
Rollup of 8 pull requests #42233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterator_step_by has decoupled their futures, so the tracking issue should split.
regression test for rust-lang#37550
|
@bors r+ p=10 |
|
📌 Commit 8ef72db has been approved by |
|
⌛ Testing commit 8ef72db with merge eb3bfb4... |
|
💔 Test failed - status-appveyor |
|
Most likely cause for the failure: #42225. See #42225 (comment) |
…excrichton Give step_trait a distinct tracking issue from step_by iterator_step_by has decoupled their futures, so the tracking issue should split. Old issue: rust-lang#27741 New issue: rust-lang#42168 r? @alexcrichton (another follow-up to closed PR rust-lang#42110 (comment))
…r=Mark-Simulacrum Remove superfluous `;;` sequences Ran across a doubled `;;` in the docstring for `str::split`. Grep found a few more. :)
…petrochenkov Fix 'associate type' typo I came across an error message mentioning an 'associate type'. Since this is the only instance of this term in rustc (it's 'associated type' everywhere else), I think this might be a typo.
Remove stray lockfile
…=Mark-Simulacrum regression tests for ICEs closes rust-lang#36379 closes rust-lang#37550 closes rust-lang#37665 closes rust-lang#38160 closes rust-lang#38954 closes rust-lang#39362 r? @Mark-Simulacrum
…slicing, r=GuillaumeGomez Update documentation for indexing/slicing methods See rust-lang#39911 r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FusedIteratorimplementation ofiter::Scan#42014, Override size_hint and propagate ExactSizeIterator for iter::StepBy #42167, Give step_trait a distinct tracking issue from step_by #42169, Remove superfluous;;sequences #42215, Fix 'associate type' typo #42216, Remove stray lockfile #42224, Support VS 2017 #42225, regression tests for ICEs #42230