Skip to content

macros: fix regression involving identifiers in macro_rules! patterns. #43224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2017

Conversation

jseyfried
Copy link
Contributor

Fixes #42019.
r? @nrc

@jseyfried jseyfried force-pushed the fix_macro_idents_regression branch from dc8c4aa to 65a5e92 Compare July 13, 2017 21:11
@nrc
Copy link
Member

nrc commented Jul 14, 2017

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 14, 2017

📌 Commit b5c5a0c has been approved by nrc

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 14, 2017
@shepmaster
Copy link
Member

FYI: typo in the commit message: fregression.

@jseyfried jseyfried changed the title macros: fregression involving identifiers in macro_rules! patterns. macros: fix regression involving identifiers in macro_rules! patterns. Jul 14, 2017
@bors
Copy link
Collaborator

bors commented Jul 15, 2017

⌛ Testing commit b5c5a0c with merge 87d8b9c0af76936881b627ba376181b05914fcc3...

@bors
Copy link
Collaborator

bors commented Jul 15, 2017

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Jul 15, 2017

i586-pc-windows-msvc failed, run-make\issue-26092 again, very likely the same as #43179 (comment). Spurious.

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Jul 15, 2017

⌛ Testing commit b5c5a0c with merge 086eaa7...

bors added a commit that referenced this pull request Jul 15, 2017
macros: fix regression involving identifiers in `macro_rules!` patterns.

Fixes #42019.
r? @nrc
@bors
Copy link
Collaborator

bors commented Jul 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 086eaa7 to master...

@bors bors merged commit b5c5a0c into rust-lang:master Jul 15, 2017
@jseyfried jseyfried deleted the fix_macro_idents_regression branch July 24, 2017 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants