Skip to content

Produce expansion info for more builtin macros #44248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2017
Merged

Produce expansion info for more builtin macros #44248

merged 1 commit into from
Sep 5, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 1, 2017

r? @jseyfried

fixes #43268

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2017
jseyfried
jseyfried reviewed Sep 1, 2017
View reviewed changes
src/librustc_lint/builtin.rs Outdated
cx.span_lint(WHILE_TRUE,
e.span,
"denote infinite loops with loop { ... }");
if lit.span.ctxt().outer().expn_info().is_none() {
Copy link
Contributor

@jseyfried jseyfried Sep 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this could just be if lit.span.ctxt() == SyntaxContext::empty() { ... }.

@jseyfried
Copy link
Contributor

Thanks! r=me with comment addressed.

@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 4, 2017

@bors r=jseyfried

@bors
Copy link
Collaborator

bors commented Sep 4, 2017

@oli-obk: 🔑 Insufficient privileges: Not in reviewers

@eddyb
Copy link
Member

eddyb commented Sep 4, 2017

@bors r=jseyfried

@bors
Copy link
Collaborator

bors commented Sep 4, 2017

📌 Commit c4d5a1e has been approved by jseyfried

@bors
Copy link
Collaborator

bors commented Sep 4, 2017

⌛ Testing commit c4d5a1e with merge 64ce9e0...

bors added a commit that referenced this pull request Sep 4, 2017
@bors
Auto merge of #44248 - oli-obk:spans, r=jseyfried
64ce9e0 
Produce expansion info for more builtin macros

r? @jseyfried

fixes #43268
@bors
Copy link
Collaborator

bors commented Sep 4, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Sep 4, 2017

@bors retry #44221

@bors
Copy link
Collaborator

bors commented Sep 4, 2017

⌛ Testing commit c4d5a1e with merge dbee0ea...

bors added a commit that referenced this pull request Sep 4, 2017
@bors
Auto merge of #44248 - oli-obk:spans, r=jseyfried
dbee0ea 
Produce expansion info for more builtin macros

r? @jseyfried

fixes #43268
@bors
Copy link
Collaborator

bors commented Sep 4, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Sep 4, 2017

@bors retry #44221 (note: 2nd try)

�[0KTesting librustc stage1 (i686-apple-darwin -> i686-apple-darwin)
[02:13:42] �[m�[m�[33m�[1mwarning:�[m a `-j` argument was passed to Cargo but Cargo is also configured with an external jobserver in its environment, ignoring the `-j` parameter
[02:13:43] �[m�[m�[32m�[1m   Compiling�[m fmt_macros v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libfmt_macros)
[02:13:46] �[m�[m�[32m�[1m   Compiling�[m arena v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libarena)
[02:13:49] �[m�[m�[32m�[1m   Compiling�[m serialize v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libserialize)
[02:14:31] �[m�[m�[32m�[1m   Compiling�[m graphviz v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libgraphviz)
[02:14:35] �[m�[m�[32m�[1m   Compiling�[m rustc_bitflags v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_bitflags)
[02:14:36] �[m�[m�[32m�[1m   Compiling�[m rustc_platform_intrinsics v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_platform_intrinsics)
[02:14:42] �[m�[m�[32m�[1m   Compiling�[m rustc_apfloat v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_apfloat)
[02:14:44] �[m�[m�[32m�[1m   Compiling�[m rustc_data_structures v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_data_structures)
[02:15:43] �[m�[m�[32m�[1m   Compiling�[m syntax_pos v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libsyntax_pos)
[02:15:47] �[m�[m�[32m�[1m   Compiling�[m rustc_errors v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_errors)
[02:15:52] �[m�[m�[32m�[1m   Compiling�[m syntax v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libsyntax)
[02:17:49] �[m�[m�[32m�[1m   Compiling�[m rustc_const_math v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_const_math)
[02:17:52] �[m�[m�[32m�[1m   Compiling�[m proc_macro v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libproc_macro)
[02:17:55] �[m�[m�[32m�[1m   Compiling�[m rustc_back v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_back)
[02:18:17] �[m�[m�[32m�[1m   Compiling�[m rustc v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc)

No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

bors added a commit that referenced this pull request Sep 5, 2017
@bors
Auto merge of #44248 - oli-obk:spans, r=jseyfried
2f681bf 
Produce expansion info for more builtin macros

r? @jseyfried

fixes #43268
@bors
Copy link
Collaborator

bors commented Sep 5, 2017

⌛ Testing commit c4d5a1e with merge 2f681bf...

@bors
Copy link
Collaborator

bors commented Sep 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: jseyfried
Pushing 2f681bf to master...

@bors bors merged commit c4d5a1e into rust-lang:master Sep 5, 2017
@oli-obk oli-obk mentioned this pull request Apr 24, 2018
Closed
@oli-obk oli-obk deleted the spans branch June 15, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jseyfried jseyfried jseyfried left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jseyfried jseyfried

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

while cfg!(unix) { ... } suggests to use loop instead
6 participants
@oli-obk @jseyfried @bors @eddyb @kennytm @shepmaster