Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Sep 2, 2017

This includes rust-lang/cargo#4447 which fixes a bug in Cargo that is needed to fix #44237.

r? @alexcrichton

This includes rust-lang/cargo#4447 which fixes
a bug in Cargo that is needed to fix
rust-lang#44237.
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 2, 2017

📌 Commit 1b758fb has been approved by alexcrichton

@Mark-Simulacrum
Copy link
Member Author

@bors p=1

@Mark-Simulacrum
Copy link
Member Author

@alexcrichton Beta-nominating: As far as I can tell, this fixes the problem I encountered when attempting to re-enable testing for librustdoc. We need to update cargo on beta for those tests to be run.

@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 2, 2017
@bors
Copy link
Collaborator

bors commented Sep 2, 2017

⌛ Testing commit 1b758fb with merge 8d83c15...

bors added a commit that referenced this pull request Sep 2, 2017
Update cargo

This includes rust-lang/cargo#4447 which fixes a bug in Cargo that is needed to fix #44237.

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Sep 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8d83c15 to master...

@bors bors merged commit 1b758fb into rust-lang:master Sep 2, 2017
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 2, 2017
@Mark-Simulacrum Mark-Simulacrum deleted the update-cargo branch September 5, 2017 11:59
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 12, 2017
@alexcrichton
Copy link
Member

I'm going to de-nominate from beta as this wasn't required to get rustdoc tests running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc unit tests not being run by Rustbuild
3 participants