Add Option::filter() according to RFC 2124
#45863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
S-waiting-on-review
1 task
dtolnay
approved these changes
Nov 8, 2017
|
@rust-lang/libs this is adding an unstable fn filter<P>(self, predicate: P) -> Self
where
P: FnOnce(&T) -> bool |
|
@bors r+ |
|
📌 Commit e652144 has been approved by |
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 10, 2017
…r=dtolnay Add `Option::filter()` according to RFC 2124 (*old PR: rust-lang#44996) This is the implementation of [RFC "Add `Option::filter` to the standard library"](rust-lang/rfcs#2124). Tracking issue: rust-lang#45860 **Questions for code reviewers:** - Is the documentation sufficiently long? - Is the documentation easy enough to understand? - Is the position of the new method (after `and_then()`) a good one?
bors
added a commit
that referenced
this pull request
Nov 10, 2017
|
I haven't been following the discussion on this closely but wouldn't this method be more flexible if the Then again, this method acts similarly to |
|
@nvzqz please mention concerns or suggestions like this in the tracking issue to have all discussion in one place. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(old PR: #44996)
This is the implementation of RFC "Add
Option::filterto the standard library". Tracking issue: #45860Questions for code reviewers:
and_then()) a good one?