incr.comp.: Incorporate the stable commandline arg hash and SVHs of upstream crates into the SVH. #46427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pstream crates in the SVH.
kennytm
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8129c53 has been approved by |
|
@bors p=1 Important to get incremental tests passing. |
bors
added a commit
that referenced
this pull request
Dec 4, 2017
incr.comp.: Incorporate the stable commandline arg hash and SVHs of upstream crates into the SVH. So far the SVH detected changes in the HIR, which is already very sensitive, but in order for `eval_always` queries to also be sensitive to changes in upstream crates, the SVH also needs to capture changes there. This PR fixes [rust-icci/crossbeam](https://travis-ci.org/rust-icci/crossbeam/builds/308936448), but I have not yet been able to come up with a minimal regression test. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the SVH detected changes in the HIR, which is already very sensitive, but in order for
eval_alwaysqueries to also be sensitive to changes in upstream crates, the SVH also needs to capture changes there.This PR fixes rust-icci/crossbeam, but I have not yet been able to come up with a minimal regression test.
r? @nikomatsakis