Skip to content

Compiletest: delete the compiled program once its test is done. #48144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Compiletest: delete the compiled program once its test is done. #48144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66ee33a
compiletest: Delete the executable immediately after running.
kennytm Feb 11, 2018
00bce71
Delete executables if the test ran successfully.
Mark-Simulacrum Feb 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/tools/compiletest/src/runtest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,7 +1343,7 @@ impl<'test> TestCx<'test> {
fn exec_compiled_test(&self) -> ProcRes {
let env = &self.props.exec_env;

match &*self.config.target {
let proc_res = match &*self.config.target {
// This is pretty similar to below, we're transforming:
//
// program arg1 arg2
Expand Down Expand Up @@ -1398,7 +1398,15 @@ impl<'test> TestCx<'test> {
None,
)
}
};

if proc_res.status.success() {
// delete the executable after running it to save space.
// it is ok if the deletion failed.
let _ = fs::remove_file(self.make_exe_name());
}

proc_res
}

/// For each `aux-build: foo/bar` annotation, we check to find the
Expand Down