Skip to content

[beta] temporarily disable rust-lang/rust#46833 due to rust-lang/rust#48251 #48379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2018
Merged

[beta] temporarily disable rust-lang/rust#46833 due to rust-lang/rust#48251 #48379

merged 1 commit into from
Feb 27, 2018

Conversation

nikomatsakis
Copy link
Contributor

see also #48378

r? @Mark-Simulacrum

@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2018
@nikomatsakis nikomatsakis mentioned this pull request Feb 21, 2018
Closed
@nikomatsakis
Copy link
Contributor Author

See FCP on the stable PR

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 23, 2018

📌 Commit 61c2258 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2018
@bors
Copy link
Collaborator

bors commented Feb 23, 2018

⌛ Testing commit 61c2258 with merge d27e1b5dcbe37e9b05ce44db85ab384056ab4564...

@bors
Copy link
Collaborator

bors commented Feb 23, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2018
@Mark-Simulacrum
Copy link
Member

@bors retry appveyor timed out

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2018
@bors
Copy link
Collaborator

bors commented Feb 24, 2018

⌛ Testing commit 61c2258 with merge 4d3a6ef1c08b45151bcb38cb516f0e05a154d2a9...

@bors
Copy link
Collaborator

bors commented Feb 24, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2018
@Mark-Simulacrum
Copy link
Member

@bors retry

We need to backport the appveyor fix to beta...

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2018
@kennytm
Copy link
Member

kennytm commented Feb 24, 2018

@bors p=8

Beta backport

@Manishearth Manishearth changed the title temporarily disable rust-lang/rust#46833 due to rust-lang/rust#48251 [beta] temporarily disable rust-lang/rust#46833 due to rust-lang/rust#48251 Feb 24, 2018
@Manishearth
Copy link
Member

@bors p=10

(we care about this one more)

@bors
Copy link
Collaborator

bors commented Feb 25, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2018
@kennytm
Copy link
Member

kennytm commented Feb 25, 2018

@bors retry

3 hour timeout in asmjs

Timing breakdown:
Step Duration (s)
make-prepare 69.27
pytest/bootstrap 0
stage0-std 78.82
stage0-test 14.64
stage0-rustc 1107.11
llvm 358.52
stage0-trans-llvm 193.11
llvm-emscripten 166.46
stage0-trans-emscripten 87.76
stage1-std 102.85
stage1-test 24.24
stage1-rustc 1788.3
stage1-trans-llvm 233.64
stage1-trans-emscripten 129.35
stage2-std 74.9
stage2-test 16.56
stage0-compiletest 57.49
test/ui 159.54
test/run-pass 4752.34
test/compile-fail 142.39
test/parse-fail 5.4
test/run-fail 217.03
test/run-pass-valgrind 18.75
test/mir-opt 85.68
test/codegen 8.4
test/codegen-units 26.41
test/incremental 172.62
test/debuginfo 0.21

run-pass tests taking 1 hr 18 min to complete? 🤔

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2018
@bors
Copy link
Collaborator

bors commented Feb 25, 2018

⌛ Testing commit 61c2258 with merge c13785b789c3855430dab856d5ca57587e378d99...

@bors
Copy link
Collaborator

bors commented Feb 25, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2018
@kennytm
Copy link
Member

kennytm commented Feb 26, 2018

@bors retry #46903

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@bors
Copy link
Collaborator

bors commented Feb 26, 2018

⌛ Testing commit 61c2258 with merge 62ad16c...

bors added a commit that referenced this pull request Feb 26, 2018
@bors
Auto merge of #48379 - nikomatsakis:issue-48251-beta, r=Mark-Simulacrum
62ad16c 
[beta] temporarily disable #46833 due to #48251

see also #48378

r? @Mark-Simulacrum
@bors
Copy link
Collaborator

bors commented Feb 26, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2018
@Mark-Simulacrum
Copy link
Member

@bors retry -- appveyor timed out

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@bors
Copy link
Collaborator

bors commented Feb 26, 2018

⌛ Testing commit 61c2258 with merge bcbe7c27325161856c25b04fa95bb5c69d4dc5b0...

@bors
Copy link
Collaborator

bors commented Feb 27, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@alexcrichton
Copy link
Member

All dist jobs completed for 62ad16c

gonna merge that manually

@alexcrichton alexcrichton merged commit 61c2258 into rust-lang:beta Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nikomatsakis @rust-highfive @Mark-Simulacrum @bors @kennytm @Manishearth @alexcrichton