Skip to content

If the projection is InProgress on the projection cache while normalizing, return that same type. #48756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ereslibre
Copy link
Contributor

This avoids an overflow under certain conditions on the compiler.

Fixes: #34260
Fixes: #47032

…zing, return that same type.

This avoids an overflow under certain conditions on the compiler.

Fixes: #34260
Fixes: #47032
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2018
@eddyb
Copy link
Member

eddyb commented Mar 6, 2018

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb Mar 6, 2018
@ereslibre
Copy link
Contributor Author

I don't know if other work was ongoing to fix this in a different way (or more structurally) than this patch. I will nevertheless have a look at the failing tests.

@nikomatsakis
Copy link
Contributor

@ereslibre thanks for the PR; it does seem this is triggering an ICE for some reason. That said, we are currently engaged in an effort to basically rewrite this code and our approach to normalization as part of the Traits Working Group. To be honest, I am inclined to avoid changing the projection code for now and instead pursue "lazy normalization", unless this fixes a dire issue for you. Would you be interested in helping with that effort instead?

@ereslibre
Copy link
Contributor Author

@nikomatsakis it's fine, not a dire issue :) Thank you so much for the great pointers, will have a look at them!

@ereslibre ereslibre closed this Mar 9, 2018
@ereslibre ereslibre deleted the bug-34260 branch March 9, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants