Skip to content

rustbuild: Add more MinGW libraries to ship #49055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2018
Merged

rustbuild: Add more MinGW libraries to ship #49055

merged 1 commit into from
Mar 17, 2018

Conversation

alexcrichton
Copy link
Member

Closes #49044

@alexcrichton alexcrichton mentioned this pull request Mar 15, 2018
Closed
retep998
retep998 reviewed Mar 15, 2018
View reviewed changes
src/bootstrap/dist.rs Outdated
@@ -227,6 +227,8 @@ fn make_win_dist(
"libwsock32.a",
"libdbghelp.a",
"libmsimg32.a",
"libcredui.a",
"libsecur32.a",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list used to be in alphabetical order. I sure do wish it could continue to be in alphabetical order.

@nikomatsakis
Copy link
Contributor

r=me once alphabetized :)

@nikomatsakis nikomatsakis self-assigned this Mar 16, 2018
@alexcrichton
Copy link
Member Author

@bors: r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Mar 16, 2018

📌 Commit 3304c76 has been approved by nikomatsakis

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 16, 2018
@alexcrichton
Copy link
Member Author

@bors: rollup

kennytm added a commit to kennytm/rust that referenced this pull request Mar 17, 2018
@kennytm
Rollup merge of rust-lang#49055 - alexcrichton:ship-more-libs, r=niko…
a2289da 
…matsakis

rustbuild: Add more MinGW libraries to ship

Closes rust-lang#49044
@kennytm kennytm mentioned this pull request Mar 17, 2018
Merged
bors added a commit that referenced this pull request Mar 17, 2018
@bors
Auto merge of #49106 - kennytm:rollup, r=kennytm
61b6bf5 
Rollup of 8 pull requests

- Successful merges: #48943, #48960, #48983, #49055, #49057, #49077, #49082, #49083
- Failed merges:
@bors bors merged commit 3304c76 into rust-lang:master Mar 17, 2018
@alexcrichton alexcrichton deleted the ship-more-libs branch March 19, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@retep998 retep998 retep998 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcrichton @nikomatsakis @bors @retep998