Skip to content

Conversation

leoyvens
Copy link
Contributor

Some code improvements I noticed while reading the code.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2018
@bors
Copy link
Collaborator

bors commented Mar 27, 2018

☔ The latest upstream changes (presumably #49202) made this pull request unmergeable. Please resolve the merge conflicts.

@leoyvens leoyvens force-pushed the small-typeck-refactorings branch from 587acb9 to b6bde1b Compare March 27, 2018 18:30
@bors
Copy link
Collaborator

bors commented Mar 29, 2018

☔ The latest upstream changes (presumably #49313) made this pull request unmergeable. Please resolve the merge conflicts.

@leoyvens leoyvens force-pushed the small-typeck-refactorings branch from b6bde1b to 6511ef3 Compare April 2, 2018 18:06
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2018

📌 Commit 6511ef3 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 3, 2018
…gs, r=nikomatsakis

Small typeck refactorings

Some code improvements I noticed while reading the code.
@bors
Copy link
Collaborator

bors commented Apr 3, 2018

☔ The latest upstream changes (presumably #49348) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 3, 2018
@leoyvens leoyvens force-pushed the small-typeck-refactorings branch from 6511ef3 to 0a3eb5c Compare April 3, 2018 13:19
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2018

📌 Commit 0a3eb5c has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 4, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 5, 2018
…gs, r=nikomatsakis

Small typeck refactorings

Some code improvements I noticed while reading the code.
@bors
Copy link
Collaborator

bors commented Apr 7, 2018

⌛ Testing commit 0a3eb5c with merge e0a9bd0...

bors added a commit that referenced this pull request Apr 7, 2018
…atsakis

Small typeck refactorings

Some code improvements I noticed while reading the code.
@bors
Copy link
Collaborator

bors commented Apr 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing e0a9bd0 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants