Tests shouldn't read from stdin. #5000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, the only reason run-pass/type-use-i1-versus-i8 is trying to do a read is because that code was left over from the original program the issue was found in. When that test is run as part of check-fast, and apparently only in that case, the test blocks indefinitely, which is bad.
bors
added a commit
that referenced
this pull request
Feb 19, 2013
As far as I can tell, the only reason run-pass/type-use-i1-versus-i8 is trying to do a read is because that code was left over from the original program the issue was found in. When that test is run as part of check-fast, and apparently only in that case, the test blocks indefinitely, which is bad.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Normalize lint messages On rustc diagnostics, we prefer to use backticks over `'`, `"`, or something else. I think we should follow their manner here. In first commit, normalizes lint messages with backticks. In second commit, updates all stderrs. In third commit, updates descriptions on lintlist. changelog: none
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Normalize lint messages in cast_precision_loss Follow-up of rust-lang#5000 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the only reason run-pass/type-use-i1-versus-i8
is trying to do a read is because that code was left over from the
original program the issue was found in. When that test is run as
part of check-fast, and apparently only in that case, the test blocks
indefinitely, which is bad.