Skip to content

Support Self for intra links paths #51357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2018
@QuietMisdreavus
Copy link
Member

I don't see how this will work if there are more than one item with self links in them, or if the item with self links in them isn't the very last thing in the crate. The place where you're setting the item ID is well before it's used, since rustdoc doesn't bother cleaning the attributes until after the code in visit_ast.rs is completely finished.

A better solution would be to replace the impl Clean<Attributes> for [ast::Attributes] with a function that takes the DocContext, the attributes, and the ID you need, to make sure it's always available. It's going to be a tedious fix (since we save the attributes on nearly everything) but it's also foolproof and doesn't rely on making sure you've properly swapped the ID in and out.

@pietroalbini pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2018
@pietroalbini
Copy link
Member

Ping from triage! What's the status on this?

@GuillaumeGomez
Copy link
Member Author

It needs big changes.

@pietroalbini
Copy link
Member

Weekly ping from triage @GuillaumeGomez! Just making sure this is not forgotten.

@TimNN
Copy link
Contributor

TimNN commented Jul 3, 2018

Ping from triage, @GuillaumeGomez: We haven't heard from you in two weeks, so we are closing this for now to keep the PR queue clean. Feel free to reopen in the future!

@TimNN TimNN closed this Jul 3, 2018
@pietroalbini pietroalbini added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2018
@GuillaumeGomez GuillaumeGomez deleted the intra-link-self branch August 19, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants