remove some oldmap::Hashmap from librustc #5201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see a few instances of LinearMap(Something,()). Wouldn't it make more sense to replace those by LinearSet? |
|
@Thiez: I agree, but I encountered several weird bug while changing HashMap into LinearMap, or LinearMap<Something, ()> to LinearSet (for example, segmentation fault or illegal instruction exception). I don't know why it happens. |
|
I rebased the patch. |
|
Unfortunately this requires another rebase. |
|
Sorry, I tried rebasing but way too many conflicts. I'm closing this; please open a new PR if you have time to rebase it, @yjh0502 . Thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
…sy-float-literal-restriction, r=flip1995 Move check for lossy whole-number floats out of `excessive_precision` changelog: Add new lint `lossy_float_literal` to detect lossy whole number float literals and move it out of `excessive_precision` again. Fixes rust-lang#5201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch some std::oldmap::HashMap to core::hashmap::linear::LinearMap.
related to #4986