Rollup of 5 pull requests #52245
Merged
Rollup of 5 pull requests #52245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It elaborates over why we have to slice the 4-size src to 2-size (same as dst).
Better docs for copy_from_slice & clone_from_slice I copy-pasted the text from clone_from_slice to copy_from_slice 😄 @steveklabnik feel free to suggest changes. edit: closes rust-lang#49769
Fix typo in error message E0277 Fix a typo we stumbled upon by accident :) r? @estebank
…g, r=oli-obk Improve lint handling in rustdoc r? @oli-obk
…meGomez Avoid unwrapping in PanicInfo doc example. Fixes rust-lang#51768.
Fix typo in E0433 docs
|
@bors: r+ p=5 |
|
📌 Commit 985c5a7 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 11, 2018
Rollup of 5 pull requests Successful merges: - #51701 (Better docs for copy_from_slice & clone_from_slice) - #52231 (Fix typo in error message E0277) - #52233 (Improve lint handling in rustdoc) - #52238 (Avoid unwrapping in PanicInfo doc example.) - #52241 (Fix typo in E0433 docs) Failed merges: r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
|
@GuillaumeGomez Just curious, why is it better to rollup the pull requests and then merge them, instead of merging them individually? Either way, the commits will be merged, right? |
|
Because like this, we merge them all at once instead of having to wait 3+ hours for each. |
|
Huh, bors seems to be really slow... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost