Skip to content

Try to fix an ICE #52673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2018
Merged

Try to fix an ICE #52673

merged 1 commit into from
Jul 27, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 24, 2018

might fix #52671

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2018
@oli-obk oli-obk mentioned this pull request Jul 24, 2018
Closed
@estebank
Copy link
Contributor

Needs test. I'll wait on the convo at #52671.

@oli-obk oli-obk force-pushed the mutable_promoted branch 2 times, most recently from 08eab04 to 44ec21f Compare July 25, 2018 12:08
@oli-obk oli-obk force-pushed the mutable_promoted branch from 44ec21f to 01d4cd5 Compare July 25, 2018 12:09
@cramertj
Copy link
Member

This looks fine to me-- thanks for the fix! cc @nagisa who reviewed #52597

@estebank
Copy link
Contributor

r=me, gating on both @nagisa and travis being happy.

@nagisa
Copy link
Member

nagisa commented Jul 26, 2018

A-ha… this seems to be a fairly specific special case. It is correct to allow it, because &mut does not really give any way to mutate the data stored within the promoted static (this is an empty array!).

Surprisingly something like &mut () does not have the same behaviour as &mut [], although they seem equally fine? cc @eddyb

@bors r=nagisa,cramertj,estebank

@bors
Copy link
Collaborator

bors commented Jul 26, 2018

📌 Commit 01d4cd5 has been approved by nagisa,cramertj,estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2018
@cramertj
Copy link
Member

Giving this a higher priority since it is blocking a number of popular crates (style-servo, regex and crates.io, as well as fuchsia) from working on nightly.

@bors p=1

@bors
Copy link
Collaborator

bors commented Jul 26, 2018

⌛ Testing commit 01d4cd5 with merge 419e60e...

bors added a commit that referenced this pull request Jul 26, 2018
@bors
Auto merge of #52673 - oli-obk:mutable_promoted, r=nagisa,cramertj,es…
419e60e 
…tebank

Try to fix an ICE

might fix #52671
@bors
Copy link
Collaborator

bors commented Jul 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa,cramertj,estebank
Pushing 419e60e to master...

@bors bors merged commit 01d4cd5 into rust-lang:master Jul 27, 2018
@oli-obk oli-obk deleted the mutable_promoted branch July 31, 2018 06:38
@pnkfelix pnkfelix mentioned this pull request Oct 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: mir_borrowck encountered mutable promoted
6 participants
@oli-obk @rust-highfive @estebank @cramertj @nagisa @bors