Suggest correct cast for struct fields with shorthand syntax #57769

estebank · 2019-01-20T04:21:14Z

error[E0308]: mismatched types
  --> $DIR/type-mismatch-struct-field-shorthand.rs:8:19
   |
LL |     let _ = RGB { r, g, b };
   |                   ^ expected f64, found f32
help: you can cast an `f32` to `f64` in a lossless way
   |
LL |     let _ = RGB { r: r.into(), g, b };
   |                   ^^^^^^^^^^^

Fix #52497.

rust-highfive · 2019-01-20T04:21:18Z

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_typeck/check/demand.rs

matthewjasper · 2019-01-20T20:37:53Z

@bors r+

bors · 2019-01-20T20:37:54Z

📌 Commit 5b44b3c has been approved by matthewjasper

…ld, r=matthewjasper Suggest correct cast for struct fields with shorthand syntax ``` error[E0308]: mismatched types --> $DIR/type-mismatch-struct-field-shorthand.rs:8:19 | LL | let _ = RGB { r, g, b }; | ^ expected f64, found f32 help: you can cast an `f32` to `f64` in a lossless way | LL | let _ = RGB { r: r.into(), g, b }; | ^^^^^^^^^^^ ``` Fix rust-lang#52497.

@ghost

Rollup of 5 pull requests Successful merges: - #56796 (Change bounds on `TryFrom` blanket impl to use `Into` instead of `From`) - #57768 (Continue parsing after parent type args and suggest using angle brackets) - #57769 (Suggest correct cast for struct fields with shorthand syntax) - #57783 (Add "dereference boxed value" suggestion.) - #57784 (Add span for bad doc comment) Failed merges: r? @ghost

Suggest correct cast for struct fields with shorthand syntax

b36bf76

rust-highfive assigned matthewjasper Jan 20, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2019

matthewjasper reviewed Jan 20, 2019

View reviewed changes

src/librustc_typeck/check/demand.rs Show resolved Hide resolved

review comment

5b44b3c

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2019

Centril mentioned this pull request Jan 21, 2019

Rollup of 5 pull requests #57792

Merged

bors merged commit 5b44b3c into rust-lang:master Jan 21, 2019

estebank deleted the cast-suggestion-struct-field branch November 9, 2023 05:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest correct cast for struct fields with shorthand syntax #57769

Suggest correct cast for struct fields with shorthand syntax #57769

estebank commented Jan 20, 2019

rust-highfive commented Jan 20, 2019

matthewjasper commented Jan 20, 2019

bors commented Jan 20, 2019

Suggest correct cast for struct fields with shorthand syntax #57769

Suggest correct cast for struct fields with shorthand syntax #57769

Conversation

estebank commented Jan 20, 2019

rust-highfive commented Jan 20, 2019

matthewjasper commented Jan 20, 2019

bors commented Jan 20, 2019