Skip to content

Remove lexical scope examples from std::mem::drop #57927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2019
Merged

Remove lexical scope examples from std::mem::drop #57927

merged 1 commit into from
Jan 27, 2019

Conversation

Alexendoo
Copy link
Member

The example no longer produces an error in the 2018 edition

@Alexendoo
Remove lexical scope examples from std::mem::drop
9c9144f 
The example no longer produces an error in the 2018 edition
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aidanhs (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2019
@Centril
Copy link
Contributor

Centril commented Jan 26, 2019

@bors rollup

@Centril
Copy link
Contributor

Centril commented Jan 27, 2019

r? @Centril

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 27, 2019

📌 Commit 9c9144f has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned aidanhs Jan 27, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 27, 2019
@Centril
Rollup merge of rust-lang#57927 - Alexendoo:mem-drop-nll-docs, r=Centril
450692e 
Remove lexical scope examples from std::mem::drop

The example no longer produces an error in the 2018 edition
@Centril Centril mentioned this pull request Jan 27, 2019
Closed
@bors
Copy link
Collaborator

bors commented Jan 27, 2019

⌛ Testing commit 9c9144f with merge 01af120...

bors added a commit that referenced this pull request Jan 27, 2019
@bors
Auto merge of #57927 - Alexendoo:mem-drop-nll-docs, r=Centril
01af120 
Remove lexical scope examples from std::mem::drop

The example no longer produces an error in the 2018 edition
@bors
Copy link
Collaborator

bors commented Jan 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 01af120 to master...

@bors bors merged commit 9c9144f into rust-lang:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Alexendoo @rust-highfive @Centril @bors @aidanhs