Skip to content

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 15, 2019

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Apr 15, 2019

📌 Commit dc08f55 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2019
@Centril
Copy link
Contributor

Centril commented Apr 15, 2019

@bors p=2

r0llup planning

@bors
Copy link
Collaborator

bors commented Apr 16, 2019

⌛ Testing commit dc08f55 with merge 7cb933a...

bors added a commit that referenced this pull request Apr 16, 2019
Use resume_unwind instead of panic!() for nicer compiletest errors

cc #58783 (comment)
@bors
Copy link
Collaborator

bors commented Apr 16, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 7cb933a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2019
@bors bors merged commit dc08f55 into rust-lang:master Apr 16, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #59990!

Tested on commit 7cb933a.
Direct link to PR: #59990

💔 rls on windows: test-pass → test-fail (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 16, 2019
Tested on commit rust-lang/rust@7cb933a.
Direct link to PR: <rust-lang/rust#59990>

💔 rls on windows: test-pass → test-fail (cc @nrc @Xanewok, @rust-lang/infra).
@bjorn3 bjorn3 deleted the nicer_compiletest_errors branch April 16, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants