Skip to content

Rollup of 16 pull requests #60099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 48 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Apr 19, 2019

Successful merges:

Failed merges:

r? @ghost

sourcefrog and others added 30 commits April 13, 2019 15:39

Verified

This commit was signed with the committer’s verified signature.
koalatux Adrian Friedli

Verified

This commit was signed with the committer’s verified signature.
koalatux Adrian Friedli

Verified

This commit was signed with the committer’s verified signature.
koalatux Adrian Friedli

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
janhohenheim Jan Hohenheim

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Stack size of 10 **bytes** does not make any sense: the minimal possible stack size is greater anyway.

Verified

This commit was signed with the committer’s verified signature.
nathankleyn Nathan Kleyn
The documentation for `rchunks_exact` said it started at the beginning
of the slice, bit it actually starts at the end of the slice.

In addition, there were a couple of "of the slice of the slice"
duplicate phrases going on for `rchunks_exact` and `rchunks_exact_mut`.

This fixes rust-lang#60068.

Unverified

This user has not yet uploaded their public signing key.
When looking at the documentation for `std::f32` or `std::str`, for
example, it is easy to get confused and assume `std::f32` and `f32`
are the same thing. Because of this, it is not uncommon to attempt
writing `f32::consts::PI` instead of the correct
`std::f32::consts::PI`. When encountering the former, which results
in an access error due to it being an inexistent path, try to access
the same path under `std`. If this succeeds, this information is
stored for later tweaking of the final E0599 to provide an
appropriate suggestion.

This suggestion applies to both E0233 and E0599 and is only checked
when the first ident of a path corresponds to a primitive type.
cuviper and others added 18 commits April 18, 2019 15:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Make clear that format padding doesn't work for Debug

As mentioned in
rust-lang#46006 (comment)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…r=QuietMisdreavus

Remove unwanted z-index change

Fixes rust-lang#60031.

r? @QuietMisdreavus

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…lexcrichton

Add codegen test for PGO instrumentation.

This PR adds a codegen test that makes sure that LLVM actually generates instrumentation code when we enable PGO instrumentation in `rustc`.

The second commit updates a test case to the new commandline option syntax introduced in rust-lang#59874. Without the fix the test still works, but it confusingly creates a directory called `test.profraw`, which usually is the name of the _file_ where profiling data is collected.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Simplify the returning of a Result a bit

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Suggest appropriate path when calling associated item on bare types

When looking at the documentation for `std::f32` or `std::str`, for
example, it is easy to get confused and assume `std::f32` and `f32`
are the same thing. Because of this, it is not uncommon to attempt
writing `f32::consts::PI` instead of the correct
`std::f32::consts::PI`. When encountering the former, which results
in an access error due to it being an inexistent path, try to access
the same path under `std`. If this succeeds, this information is
stored for later tweaking of the final E0599 to provide an
appropriate suggestion.

Fix rust-lang#26760, fix rust-lang#46660.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… r=estebank

Correct unused parameter diagnostic

The message was incorrect for unused lifetime parameters. There's no need to be specific.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ichton

Update rustfmt to 1.2.1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
whitelist RTM x86 target cpu feature

This PR adds support for intels restricted transactional memory cpu feature. I mostly copied what was done for the [movbe](rust-lang#57999) feature.

rust-lang/stdarch#718

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Change suggestion of field when not in self context

Fix rust-lang#60057.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Use more realistic example for thread builder

Stack size of 10 **bytes** does not make any sense: the minimal possible stack size is greater anyway.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.

The documentation for `rchunks_exact` said it started at the beginning
of the slice, bit it actually starts at the end of the slice.

In addition, there were a couple of "of the slice of the slice"
duplicate phrases going on for `rchunks_exact` and `rchunks_exact_mut`.

This fixes rust-lang#60068.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Update miri

r? @RalfJung

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ate, r=cramertj

Feature gate async methods

Fixes rust-lang#60069.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…, r=rkruppe

Use -mergefunc-use-aliases for any LLVM >= 8

This functionality is not specific to Rust's LLVM, but any starting in LLVM 8.0,
as noted in <rust-lang#56358 (comment)>.

cc @nikic
r? @rkruppe
@Centril Centril closed this Apr 19, 2019
@Centril Centril deleted the rollup-mkdox0z branch April 19, 2019 00:25
@rust-highfive
Copy link
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet