Skip to content

Remove assumption from recovery code #60119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Conversation

estebank
Copy link
Contributor

Fix #60115.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2019
@estebank
Copy link
Contributor Author

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned eddyb Apr 19, 2019
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 20, 2019

📌 Commit 30b779f has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2019
@bors
Copy link
Collaborator

bors commented Apr 21, 2019

⌛ Testing commit 30b779f with merge 21b777238f65434b66ae973835aa6a433e133340...

@bors
Copy link
Collaborator

bors commented Apr 21, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 21, 2019
@rust-highfive
Copy link
Contributor

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:52:17] test string::test_str_truncate ... ok
[01:52:17] test string::test_str_truncate_invalid_len ... ok
[01:52:17] test string::test_str_add ... ok
[01:52:17] test string::test_str_truncate_split_codepoint ... ok
[01:52:17] died due to signal 11
[01:52:17] 
[01:52:17] 
[01:52:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:52:17] expected success, got: exit code: 3
---
travis_time:end:022d104d:start=1555831140299442079,finish=1555831140316834116,duration=17392037
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:27bc3d3e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c6223ec
travis_time:start:0c6223ec
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0779de66
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@davidtwco
Copy link
Member

@bors retry #55861

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2019
@bors
Copy link
Collaborator

bors commented Apr 21, 2019

⌛ Testing commit 30b779f with merge 06a271a...

bors added a commit that referenced this pull request Apr 21, 2019
Remove assumption from recovery code

Fix #60115.
@bors
Copy link
Collaborator

bors commented Apr 21, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: davidtwco
Pushing 06a271a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2019
@bors bors merged commit 30b779f into rust-lang:master Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser panics on Invalid syntax pub some_name(); when inside mod
5 participants