Revert "Update Source Code Pro fonts to version 2.030" #60382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6bafc58.
rust-highfive
added
the
S-waiting-on-review
|
Thanks! @bors: r+ rollup |
|
📌 Commit 7aab005 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…llaumeGomez Revert "Update Source Code Pro fonts to version 2.030" Temporary fix for rust-lang#60365 rust-lang#60146 updated all fonts (not just the fonts that were buggy), however it looks like the new Source Code Pro is buggy. We should test this out of tree: `cargo doc` on anything, replace the font in `target/doc`, and use `python -m SimpleHTTPServer` to see what's going on. Till we figure that out, I'll just back this out. r? @GuillaumeGomez This reverts commit 6bafc58.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…llaumeGomez Revert "Update Source Code Pro fonts to version 2.030" Temporary fix for rust-lang#60365 rust-lang#60146 updated all fonts (not just the fonts that were buggy), however it looks like the new Source Code Pro is buggy. We should test this out of tree: `cargo doc` on anything, replace the font in `target/doc`, and use `python -m SimpleHTTPServer` to see what's going on. Till we figure that out, I'll just back this out. r? @GuillaumeGomez This reverts commit 6bafc58.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…llaumeGomez Revert "Update Source Code Pro fonts to version 2.030" Temporary fix for rust-lang#60365 rust-lang#60146 updated all fonts (not just the fonts that were buggy), however it looks like the new Source Code Pro is buggy. We should test this out of tree: `cargo doc` on anything, replace the font in `target/doc`, and use `python -m SimpleHTTPServer` to see what's going on. Till we figure that out, I'll just back this out. r? @GuillaumeGomez This reverts commit 6bafc58.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…llaumeGomez Revert "Update Source Code Pro fonts to version 2.030" Temporary fix for rust-lang#60365 rust-lang#60146 updated all fonts (not just the fonts that were buggy), however it looks like the new Source Code Pro is buggy. We should test this out of tree: `cargo doc` on anything, replace the font in `target/doc`, and use `python -m SimpleHTTPServer` to see what's going on. Till we figure that out, I'll just back this out. r? @GuillaumeGomez This reverts commit 6bafc58.
bors
added a commit
that referenced
this pull request
Apr 30, 2019
Rollup of 7 pull requests Successful merges: - #60344 (Don't try to render auto-trait bounds with any inference variables) - #60354 (Cleanup declare_features! for 'accepted' with a uniform style + sort them) - #60362 (Cleanup 'active' declare_features! with uniform style + sorting.) - #60382 (Revert "Update Source Code Pro fonts to version 2.030") - #60399 (Update clippy) - #60400 (Remove functions to simplify handling of feature(bind_by_move_pattern_guards)) - #60408 (Add missing f16c_target_feature check to typeck collect) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #60365
#60146 updated all fonts (not just the fonts that were buggy), however it looks like the new Source Code Pro is buggy.
We should test this out of tree:
cargo docon anything, replace the font intarget/doc, and usepython -m SimpleHTTPServerto see what's going on.Till we figure that out, I'll just back this out.
r? @GuillaumeGomez
This reverts commit 6bafc58.