Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 25, 2019

Fixes #62939.

cc @pravic

screenshot of the result:

Screenshot from 2019-07-25 14-29-48

r? @QuietMisdreavus

@GuillaumeGomez
Copy link
Member Author

@pietroalbini Once again the bot didn't show up. I guess this is still not fixed. :-/

@jonas-schievink jonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 26, 2019
@GuillaumeGomez
Copy link
Member Author

Very small add and no news since a while so let's just get it in (since no news...).

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 31, 2019

📌 Commit 08a8de8 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2019
@GuillaumeGomez
Copy link
Member Author

@bors: r=nobody

@bors
Copy link
Collaborator

bors commented Jul 31, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Jul 31, 2019

📌 Commit 08a8de8 has been approved by nobody

Centril added a commit to Centril/rust that referenced this pull request Jul 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 1, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 1, 2019
bors added a commit that referenced this pull request Aug 1, 2019
Rollup of 8 pull requests

Successful merges:

 - #62644 (simplify std::io::Write::write rustdoc)
 - #62971 (Add keywords item into the sidebar)
 - #63122 (Account for `maybe_whole_expr` in range patterns)
 - #63158 (Add test for issue-58951)
 - #63170 (cleanup StringReader fields)
 - #63179 (update test cases for vxWorks)
 - #63188 (Fix typos in release notes.)
 - #63191 (ci: fix toolstate not pushing data for Linux)

Failed merges:

r? @ghost
@bors bors merged commit 08a8de8 into rust-lang:master Aug 1, 2019
@GuillaumeGomez GuillaumeGomez deleted the keyword-sidebar branch August 2, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Add a link to the keywords list
4 participants