librustc: Make extern functions no longer of *u8 type.
#6491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can perhaps be restored in the future. For now this is a precursor to making typedefs work as expected.
Calling them LLVM asserts still, but that never worked anyway. This is the backwards compatible part.
|
👻 |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 20, 2021
…ednet `while_let_on_iterator` Improvements fixes: rust-lang#6491 fixes: rust-lang#6231 fixes: rust-lang#5844 fixes: rust-lang#1924 fixes: rust-lang#1033 The check for whether a field can be borrowed should probably be moved to utils at some point, but it would require some cleanup work and knowing what parts can actually be shared. changelog: Suggest `&mut iter` when the iterator is used after the loop. changelog: Suggest `&mut iter` when the iterator is a field in a struct. changelog: Don't lint when the iterator is a field in a struct, and the struct is used in the loop. changelog: Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson