Skip to content

vxworks: add checking (r == 0) #65228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

BaoshanPang
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2019
@Centril Centril changed the title add checking (r == 0) vxworks: add checking (r == 0) Oct 9, 2019
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping because based on #61946 (comment) and #61946 (review) we haven't been carefully reviewing the src/libstd/sys/vxworks directory.

In the future it would be courteous to give a brief explanation of what bug is being fixed.

@dtolnay
Copy link
Member

dtolnay commented Oct 9, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 9, 2019

📌 Commit 175db95 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2019
@BaoshanPang
Copy link
Contributor Author

@dtolnay

Thanks for approve it.
This change is to align with the code in libstd/sys/unix/rwlock.c, we don't see any test case fail due this change is not added though.

@bors
Copy link
Collaborator

bors commented Oct 9, 2019

⌛ Testing commit 175db95 with merge 20cc752...

bors added a commit that referenced this pull request Oct 9, 2019
@bors
Copy link
Collaborator

bors commented Oct 9, 2019

☀️ Test successful - checks-azure
Approved by: dtolnay
Pushing 20cc752 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2019
@bors bors merged commit 175db95 into rust-lang:master Oct 9, 2019
@BaoshanPang BaoshanPang deleted the real_master branch November 11, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants