rustc_plugin: Remove support for syntactic plugins #66647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
This is a full version of #64665 (@matklad @Mark-Simulacrum ) |
|
r=me with comments addressed (except for the second re. llvm) |
Centril
added
S-waiting-on-author
|
ping @rust-lang/compiler @rust-lang/lang |
|
I think I remember us already signing off on the removal of plugins in another issue? I don't think we need to sign off again. |
|
@bors r=Centril |
|
📌 Commit f89e6c8 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Nov 25, 2019
Remove failing plugin tests. Some rustc plugin features have been removed in rust-lang/rust#66647, so these tests can no longer pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the plugin interface was successfully replaced by token-based procedural macros in theory and in practice.
cc #29597
cc #64675
r? @Centril