Skip to content

Ensure there are versions of test code for aarch64 windows #70600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

danielframpton
Copy link
Contributor

@danielframpton danielframpton commented Mar 31, 2020

Remove the cfg flags that were preventing some tests from running on aarch64-pc-windows-msvc.

All the existing target_os = windows targets had the same align() and size() values, so this change just removes the target_arch flags.

r? @alexcrichton

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Mar 31, 2020

📌 Commit d195620 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#69425 (add fn make_contiguous to VecDeque)
 - rust-lang#69458 (improve folder name for persistent doc tests)
 - rust-lang#70268 (Document ThreadSanitizer in unstable-book)
 - rust-lang#70600 (Ensure there are versions of test code for aarch64 windows)
 - rust-lang#70606 (Clean up E0466 explanation)
 - rust-lang#70614 (remove unnecessary relocation check in const_prop)
 - rust-lang#70623 (Fix broken link in README)

Failed merges:

r? @ghost
@bors bors merged commit b954607 into rust-lang:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants