Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Apr 7, 2020

moves extend_cause_with_original_assoc_item_obligation out of compute_trait_ref and
changes trait_assoc_items to an iterator. This saves us from building an unnecessary Vec<_>

r? @eddyb i guess

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2020
@eddyb
Copy link
Member

eddyb commented Apr 7, 2020

cc @estebank r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb Apr 7, 2020
@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 8, 2020

📌 Commit ab4178b has been approved by nikomatsakis

@bors
Copy link
Collaborator

bors commented Apr 8, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 8, 2020
Rollup of 9 pull requests

Successful merges:

 - rust-lang#70789 (remove false positives of unused_braces)
 - rust-lang#70847 (ci: move /var/lib/docker to /mnt on GHA)
 - rust-lang#70850 (BTreeMap first last proposal tweaks)
 - rust-lang#70876 (Use a `SmallVec` for `Cache::predecessors`.)
 - rust-lang#70883 (Clean up E0507 explanation)
 - rust-lang#70892 (wf: refactor `compute_trait_ref`)
 - rust-lang#70914 (Corrects a typo in rustdoc documentation.)
 - rust-lang#70915 (Remove unnecessary TypeFlags::NOMINAL_FLAGS)
 - rust-lang#70927 (Clean up E0510 explanation)

Failed merges:

r? @ghost
@bors bors merged commit e3346e5 into rust-lang:master Apr 8, 2020
@lcnr lcnr deleted the interators_are_nice branch April 8, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants